Sort related automations, scripts and scenes on device info page #23740
Conversation
jpbede
changed the title
| private _toEntities = memoizeOne((entityIds: string[]) => | ||
| entityIds.map((entityId) => this.hass.states[entityId]) | ||
| ); |
There was a problem hiding this comment.
This change will defeat the purpose of MemoizeOne here. You can read about MemoizeOne here: https://www.npmjs.com/package/memoize-one#usage
Previously, we had individual MemoizeOne on entities, groups, automations, scripts, ...
So, if the related scripts don't change, memoize will return the cache result fast upon each rendering.
With these changes, only one MemoizeOne remains and since we fetch related entities, groups, automations, scripts and so on in sequence, it will never be able to return the cache.
There was a problem hiding this comment.
I would make this 1 memoized function, that returns all the sorted and filtered entities:
private _getRelated_ = memoizeOne((this._related) => {entity: [], automation: [], ... });
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
|
||
| Object.keys(related).forEach((key) => { | ||
| related[key] = related[key] | ||
| .map((id: string) => hass.states[id]) |
There was a problem hiding this comment.
Not all related items are entities, so this does not makes sense. Only for scenes, scripts, automations and entity it makes sense.
| related[key] = related[key] | ||
| .map((id: string) => hass.states[id]) | ||
| .filter(Boolean) | ||
| .sort((a: HassEntity, b: HassEntity) => |
There was a problem hiding this comment.
If an entity name is changed after we fetched related, it will not update the sorting, that is kinda weird.
Proposed change
Sort the related automations, scripts and scenes on the device info page as we already do in the more-info dialog.
Instead of copying the code for the sorting, I moved it to a central place (I hope the right one, otherwise please suggest the right one 🙂) and adjusted the related items in the more-info dialog to use it.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: